Opportunistically delete ignored documents #130
Merged
+187
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ignorelist contents and logic may change over time, and we want to delete any documents that may exist remotely but are now covered by the ignorelist.
We've set deletion up as an idempotent operation anyway, so there is no harm in firing off an opportunistic delete request when a document is ignored.
info
rather thanwarn
log message, and remove TODO comment now that our approach is final