Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opportunistically delete ignored documents #130

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

csutter
Copy link
Contributor

@csutter csutter commented Nov 29, 2023

The ignorelist contents and logic may change over time, and we want to delete any documents that may exist remotely but are now covered by the ignorelist.

We've set deletion up as an idempotent operation anyway, so there is no harm in firing off an opportunistic delete request when a document is ignored.

  • Attempt to delete documents remotely that come through as ignored
  • Add an example ignored message to integration tests
  • Make documents not existing on deletion an info rather than warn log message, and remove TODO comment now that our approach is final
  • Fix incorrectly named mock object

The ignorelist contents and logic may change over time, and we want to
delete any documents that may exist remotely but are now covered by the
ignorelist.

We've set deletion up as an idempotent operation anyway, so there is no
harm in firing off an opportunistic delete request when a document is
ignored.

- Attempt to delete documents remotely that come through as ignored
- Add an example ignored message to integration tests
- Make documents not existing on deletion an `info` rather than `warn`
  log message, and remove TODO comment now that our approach is final
- Fix incorrectly named mock object
@csutter csutter merged commit bb2ac75 into main Nov 29, 2023
7 checks passed
@csutter csutter deleted the delete-on-ignore branch November 29, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant